Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sync UI #356

Closed
bbondy opened this issue Jun 15, 2018 · 6 comments
Closed

Implement Sync UI #356

bbondy opened this issue Jun 15, 2018 · 6 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jun 15, 2018

Once @AlexeyBarabash is done with the sync functionality, he will pass this to @cezaraugusto for making the UI use React/Redux and match browser-laptop's look.

@bbondy bbondy added this to the Releasable builds milestone Jun 15, 2018
@bsclifton
Copy link
Member

bsclifton commented Jun 18, 2018

browser-laptop implementation of the Sync v2 UI available here:
brave/browser-laptop#13197

Important issues to consider when implementing (we can create separate issues for these):

@rebron rebron removed this from the 0.57.x - Dev milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 30, 2018
@cezaraugusto
Copy link
Contributor

task is completed so closing

@bradleyrichter
Copy link

@cezaraugusto the beta build appears to have Sync v1 in it. Where is the new V2 hiding?

@cezaraugusto cezaraugusto mentioned this issue Nov 13, 2018
5 tasks
@bbondy bbondy modified the milestones: 1.x Backlog, 0.58.x - Beta Dec 2, 2018
@bbondy bbondy added the QA/Yes label Dec 2, 2018
@srirambv
Copy link
Contributor

@bradleyrichter @cezaraugusto Should the verification be done against the current V1 UI or should we wait until V2 UI is implemented?

cc: @bbondy @rebron @kjozwiak

@cezaraugusto
Copy link
Contributor

since we want to sync v2 to land in 0.58.x I'd wait for it

@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2019

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

Verification PASSED on Mint 18.3 x64 using the following build:

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants