Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] regression in unknown_processes:reported_by_chrome:partition_alloc:max_allocated_size at v1.63.18 #35645

Closed
atuchin-m opened this issue Jan 28, 2024 · 4 comments
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop perf perf-regression An perf browser issue by the perf dashboard QA/No release-notes/exclude

Comments

@atuchin-m
Copy link
Contributor

Revision range: brave/brave-core@v1.63.14...v1.63.18
Win 11, mac x64 & arm64
https://brave-perf-dashboard.appspot.com/report?sid=75b4dd3a56c456c0308ecd167a0e918acbae731ecce756a6ecbaeae808a9bc75
image

@atuchin-m atuchin-m added perf OS/Android Fixes related to Android browser functionality OS/Desktop perf-regression An perf browser issue by the perf dashboard labels Jan 28, 2024
@atuchin-m atuchin-m self-assigned this Jan 28, 2024
@atuchin-m
Copy link
Contributor Author

There also a regression in reported_by_chrome:allocated_objects_size, not just max_allocated_size
https://brave-perf-dashboard.appspot.com/report?sid=88b1722134def223fcd8b280d258b77003d94dd5a0ac1d29d3827c46d34e595d

@atuchin-m
Copy link
Contributor Author

It's a regression, detected on the old revisions after enabling anomaly detector.
The reason is bumping WDP: brave/brave-core#20961

It turns out that WDP consumes CPU and memory even it's explicitly disabled in the settings.
IMHO it isn't good for the end users and should be fixed.

Screenshot 2024-02-14 at 21 55 35 Screenshot 2024-02-14 at 21 55 55

@atuchin-m atuchin-m added this to the 1.66.x - Nightly milestone Apr 3, 2024
@kjozwiak
Copy link
Member

kjozwiak commented May 9, 2024

@atuchin-m assuming the above can be closed as brave/brave-core#22756 is also in 1.66.x? Should the above be labelled as QA/Yes? If so, mind adding some STR/Cases? If this is something the performance team has already checked/verified, we can label as QA/No and close it off.

@atuchin-m
Copy link
Contributor Author

The performance fix was verified by the dashboard.
As for WDP @remusao checked thay it's good for nighty.
So I'm adding QA/No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop perf perf-regression An perf browser issue by the perf dashboard QA/No release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants
@kjozwiak @atuchin-m and others