Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition between fetching token registry and asset discovery on wallet restore #35696

Closed
nvonpentz opened this issue Jan 30, 2024 · 0 comments · Fixed by brave/brave-core#22263
Closed

Race condition between fetching token registry and asset discovery on wallet restore #35696

nvonpentz opened this issue Jan 30, 2024 · 0 comments · Fixed by brave/brave-core#22263
Assignees
@josheleonard
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include

Comments

@nvonpentz
Copy link
Member

Asset discovery only looks for tokens that are on our registry, and if the registry is empty because it hasn't been pulled down yet, no tokens will be be discovered.

Can reproduce by restoring QA wallet using an empty user-data-dir and seeing tokens do not immediately appear after initial restore.
@nvonpentz nvonpentz mentioned this issue Jan 30, 2024
Open
@nuo-xu nuo-xu mentioned this issue Feb 1, 2024
Closed
11 tasks
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 2, 2024
@StephenHeaps StephenHeaps mentioned this issue Feb 6, 2024
Merged
11 tasks
@nuo-xu nuo-xu mentioned this issue Feb 13, 2024
Merged
24 tasks
@josheleonard josheleonard mentioned this issue Feb 22, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: auto-discover assets after wallet onboarding completion brave/brave-core
3 participants
@jamesmudgett @nvonpentz @josheleonard