Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Share button gone after toggling Reader Mode for current tab #36101

Closed
Uni-verse opened this issue Dec 6, 2023 · 4 comments · Fixed by brave/brave-ios#8572 or brave/brave-core#23711
Assignees
Labels

Comments

@Uni-verse
Copy link
Contributor

Description:

Share button gone after toggling Reader Mode for current tab.

related to brave/brave-ios#8173

Steps to Reproduce

  1. Load news article
  2. Enable Reader Mode
  3. Disable Reader Mode
  4. Observe share button in bottom toolbar

Actual result:

sharebutton_readermode1.mov

Expected result:

Share button should not be replace with forward button

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version:

1.61 (23.12.4.19)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? N/A
  • Can you reproduce this issue with the current build from AppStore? No (new feature)

Device details:

iPhone X, iOS 16.7

@Uni-verse
Copy link
Contributor Author

Reopening due to issue not being fixed.

@Uni-verse Uni-verse reopened this Jan 11, 2024
@soner-yuksel soner-yuksel self-assigned this Jan 30, 2024
@soner-yuksel soner-yuksel transferred this issue from brave/brave-ios Feb 14, 2024
@soner-yuksel soner-yuksel reopened this Feb 14, 2024
@soner-yuksel soner-yuksel added the OS/iOS Fixes related to iOS browser functionality label Feb 14, 2024
@soner-yuksel soner-yuksel changed the title Share button gone after toggling Reader Mode for current tab [iOS] Share button gone after toggling Reader Mode for current tab Feb 14, 2024
@soner-yuksel soner-yuksel added this to the 1.63.x - Release milestone Feb 14, 2024
@soner-yuksel
Copy link

Issue is not fixed and reopened after transferring to brave browser

@kjozwiak
Copy link
Member

Removing from the 1.63.x milestone. Once the above has been fixed, it will land in master and then will need to be uplifted into 1.63.x. Once it lands in master (which is 1.65.x at this time), the issue will automatically close/move into the 1.65.x milestone. It will then be moved to the appropriate milestone when uplifted.

@hffvld
Copy link
Contributor

hffvld commented Jul 2, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.68 (101)
BraveCore: 1.68.101 (126.0.6478.126)

STEPS:

  1. Follow the STR/TP from [iOS] Share button gone after toggling Reader Mode for current tab brave-core#23711 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Share button is not hidden/replaced when disabling Reader Mode

1 2
1 2
2024-07-01_17-00-01.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment