Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-updater fails to handle single update request for multiple components #3615

Closed
jumde opened this issue Mar 7, 2019 · 3 comments · Fixed by brave/brave-core#1581
Closed

Comments

@jumde
Copy link
Contributor

jumde commented Mar 7, 2019

Description

Go-updater fails to handle single update request with Google and Brave components. We need to handle this so updates to CRLSets are handled correctly.

Test Plan

  1. Navigate to brave://components
  2. Verify that brave/google components are installed correctly.
@rebron
Copy link
Collaborator

rebron commented Mar 15, 2019

@jumde Is this deployed?

@jumde
Copy link
Contributor Author

jumde commented Mar 15, 2019

@rebron - It should be addressed by: brave/brave-core#1581

Landing soon on master :)

@LaurenWags
Copy link
Member

LaurenWags commented May 8, 2019

Verified passed with

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

image

Verification passed on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux
  • Verified profile folder contained 5140 folder under <Data-Dir>/CertificateRevocation/
  • Verified MEI Preload | Brave Local Data Updater | Brave Ad Block Updater | Brave Tor Client Updater (OS) | CRLSet | PDF Viewer (PDF.js) and Brave HTTPS Everywhere Updater all contained non-zero values when new profile is launched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment