-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental adblock filter list for risky rules #36244
Comments
Could be safe, but I wasn't willing to test again on the possible breakages, given the recent history of the similar filter rule.
|
Another set of rules worth testing
Already added to AG by AdguardTeam/AdguardFilters#172178 and we will eventually add to uBlock filters, just unsure whether yt is no more watching us. |
|
The Experimental list was turned on in Nightly and Beta via Griffin: https://github.com/brave/brave-variations/blob/production/seed/seed.json#L2597, closing this out. |
We'd like to test out risky filter rules before releasing widely. Even after QA, we can't capture all cases of rule-related breakage, especially on fast-moving and complex websites like YouTube. We currently don't have a way of restricting filter rule rollout by channel i.e. we can't say that a filter rule should only get applied in Nightly or Beta as opposed to Release.
As a workaround, we could have an experimental/risky adblock list/component that:
This way, we can put in risky adblock rules into this list and try them out in Nightly and Beta, and if everything looks good for a while, we can manually copy them over to the respective adblock list/component that would get sent out to all channels.
When putting in rules to the experimental list, we should make sure to tag @brave/qa-team since by definition these are risky rules that might affect QA testing.
Work Plan:
The text was updated successfully, but these errors were encountered: