Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml out of date #36271

Closed
rillian opened this issue Feb 21, 2024 · 0 comments · Fixed by brave/brave-core#21759
Closed

Cargo.toml out of date #36271

rillian opened this issue Feb 21, 2024 · 0 comments · Fixed by brave/brave-core#21759
Assignees
Labels
dev-concern feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude

Comments

@rillian
Copy link

rillian commented Feb 21, 2024

Description

//brave/third-party/rust/Cargo.toml has gotten out of sync with the code we're building. This was inevitable since we've been maintaining the vendored rust code manually without proper automation. But currently, the cargo command rejects the declared configuration, which while not affecting the build, prevents running rust-oriented tooling which is helpful in review. Cleaning this up should also help with efforts to get gnrt working for us so we do have some automation.

Steps to Reproduce

  1. cd brave/third_party/rust
  2. cargo check

Actual result:

An error is returned

Expected result:

Should run to completion with no source changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants