Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce patching for webui polymer component behavior injection #3631

Closed
petemill opened this issue Mar 8, 2019 · 0 comments · Fixed by brave/brave-core#1802
Closed

Reduce patching for webui polymer component behavior injection #3631

petemill opened this issue Mar 8, 2019 · 0 comments · Fixed by brave/brave-core#1802

Comments

@petemill
Copy link
Member

petemill commented Mar 8, 2019

Follow-up from brave/brave-core#1213 as requested by @bridiver - this new technique for minimizing patching (adding a Polymer brave behavior to a chromium component) is great, but it means 2 lines of patching for every modified component. Instead we can create create a single patch that contains a map of all component modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment