Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Remove All button when there are no entries for connected Dapps #36430

Open
srirambv opened this issue Feb 28, 2024 · 1 comment
Open
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support iPhone-specific OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 28, 2024

Description:

Disable Remove All button when there are no entries for connected Dapps

Steps to Reproduce

  1. Create a new wallet on 1.63
  2. Go to Accounts settings and select Security
  3. Remove All button is enabled
  4. Click the button, shows confirmation message to remove 0 websites

Actual result:

Expected result:

Disable Remove All button when there are no linked Dapps

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 13 (iOS 17.6) & iPhone 7+ (iOS 16.8.1)

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?NA
  • Is the issue reproducible on the latest version of Mobile Safari? NA

Additional Information

cc: @StephenHeaps @nuo-xu

@srirambv srirambv added OS/iOS Fixes related to iOS browser functionality bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support labels Feb 28, 2024
@StephenHeaps
Copy link

This one doesn't seem to reproduce every time which is odd, even after adding connection and removing it. I can't currently reproduce it on device or simulator on iOS 16/17 (iPhone 13 (iOS 17.6) & iPhone 7+ (iOS 16.8.1) mentioned as reproduced in issue).

Remove.All.Disabled.mp4
Remove.All.after.deleting.DApp.Connections.mp4

The current code is specifically disabling this already, too: https://github.com/brave/brave-core/blob/master/ios/brave-ios/Sources/BraveWallet/Settings/DappsSettings.swift#L166

@StephenHeaps StephenHeaps removed their assignment Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support iPhone-specific OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude
Projects
Status: Backlog
Development

No branches or pull requests

2 participants