iOS unit tests sometimes fail on CI citing an xctest failure

[kylehickinson]

Description:

Sometimes CI fails with the error: xctest encountered an error (Test runner never began executing tests after launching)

Upon inspecting the workspaces xctestresult file you can find a similar spindump on all failed builds:

168  start + 2360 (dyld + 24800) [0x102b9e0e0]
  168  start_sim + 20 (dyld + 5444) [0x102ae9544]
    168  ??? (xctest + 18468) [0x102a90824]
      168  ??? (XCTestCore + 20500) [0x103fed014]
        168  ??? (XCTestCore + 207088) [0x10401a8f0]
          168  ??? (XCTestCore + 207892) [0x10401ac14]
            168  ??? (XCTestCore + 215240) [0x10401c8c8]
              168  -[NSBundle loadAndReturnError:] + 304 (Foundation + 5505928) [0x180cd7388]
                168  _CFBundleLoadExecutableAndReturnError + 316 (CoreFoundation + 137344) [0x180385880]
                  168  _CFBundleDlfcnLoadBundle + 188 (CoreFoundation + 348132) [0x1803b8fe4]
                    168  dyld4::APIs::dlopen_from(char const*, int, void*) + 1108 (dyld + 142232) [0x102b0ab98]
                      168  dyld4::Loader::runInitializersBottomUpPlusUpwardLinks(dyld4::RuntimeState&) const + 264 (dyld + 68312) [0x102af8ad8]
                        168  dyld4::Loader::runInitializersBottomUpPlusUpwardLinks(dyld4::RuntimeState&) const::$_1::operator()() const + 92 (dyld + 79380) [0x102afb614]
                          168  dyld4::Loader::runInitializersBottomUp(dyld4::RuntimeState&, dyld3::Array<dyld4::Loader const*>&) const + 180 (dyld + 67936) [0x102af8960]
                            168  dyld4::Loader::runInitializersBottomUp(dyld4::RuntimeState&, dyld3::Array<dyld4::Loader const*>&) const + 216 (dyld + 67972) [0x102af8984]
                              168  dyld4::JustInTimeLoader::runInitializers(dyld4::RuntimeState&) const + 32 (dyld + 88860) [0x102afdb1c]
                                168  dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const + 384 (dyld + 67152) [0x102af8650]
                                  168  dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const + 376 (dyld + 219560) [0x102b1d9a8]
                                    168  dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const + 164 (dyld + 182756) [0x102b149e4]
                                      168  dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const + 284 (dyld + 181976) [0x102b146d8]
                                        168  invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const + 488 (dyld + 186740) [0x102b15974]
                                          168  invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const + 332 (dyld + 220796) [0x102b1de7c]
                                            168  invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const::$_0::operator()() const + 152 (dyld + 79260) [0x102afb59c]
                                              168  _GLOBAL__sub_I_whats_new_screenshot_view_controller.mm + 24 (BraveCore + 66488904) [0x283f68a48]
                                                168  __cxx_global_var_init + 56 (BraveCore + 66488832) [0x283f68a00]
                                                  168  -[UIDevice userInterfaceIdiom] + 60 (UIKitCore + 8108136) [0x184eda868]
                                                    168  _dispatch_once_callout + 28 (libdispatch.dylib + 21808) [0x18016e530]
                                                      168  _dispatch_client_callout + 16 (libdispatch.dylib + 15676) [0x18016cd3c]
                                                        168  __initializeActiveUserInterfaceIdiom_block_invoke + 68 (UIKitCore + 8113540) [0x184edbd84]
                                                          168  _dispatch_once_callout + 28 (libdispatch.dylib + 21808) [0x18016e530]
                                                            168  _dispatch_client_callout + 16 (libdispatch.dylib + 15676) [0x18016cd3c]
                                                              168  ___UIDeviceNativeUserInterfaceIdiom_block_invoke + 56 (UIKitCore + 8105584) [0x184ed9e70]
                                                                168  -[_UIDeviceInitialDeviceConfigurationLoader initialDeviceContext] + 88 (UIKitCore + 8246928) [0x184efc690]
                                                                  168  -[_UIApplicationConfigurationLoader applicationInitializationContext] + 20 (UIKitCore + 8245364) [0x184efc074]
                                                                    168  -[_UIApplicationConfigurationLoader _loadInitializationContext] + 120 (UIKitCore + 8244780) [0x184efbe2c]
                                                                      168  _dispatch_once_wait + 112 (libdispatch.dylib + 17764) [0x18016d564]
                                                                        168  __ulock_wait + 8 (libsystem_kernel.dylib + 10204) [0x103ad27dc]
                                                                         *168  ??? (kernel.release.t6000 + 5825708) [0xfffffe0008ac64ac] (blocked by turnstile waiting for xctest [24944] [unique pid 1810544] thread 0x14135f9)

Where 168 _GLOBAL__sub_I_whats_new_screenshot_view_controller.mm + 24 (BraveCore + 66488904) [0x283f68a48] is the interesting part