Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache AdBlock DAT files client side #36539

Closed
cuba opened this issue Mar 4, 2024 · 2 comments · Fixed by brave/brave-core#22127
Closed

Cache AdBlock DAT files client side #36539

cuba opened this issue Mar 4, 2024 · 2 comments · Fixed by brave/brave-core#22127
Assignees
@cuba
Labels
enhancement feature/shields/adblock Blocking ads & trackers with Shields OS/iOS Fixes related to iOS browser functionality privacy QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.66.x - Release

Comments

@cuba
Copy link

cuba commented Mar 4, 2024 •
edited
Loading

Description:

iOS version of #27161

If we load from dat files during launch this significantly improves the launch performance.
@cuba cuba added QA/Yes OS/iOS Fixes related to iOS browser functionality labels Mar 4, 2024
@cuba cuba self-assigned this Mar 4, 2024
@cuba cuba mentioned this issue Mar 4, 2024
Open
@cuba cuba added feature/shields The overall Shields feature in Brave. feature/shields/adblock Blocking ads & trackers with Shields enhancement and removed feature/shields The overall Shields feature in Brave. labels Mar 4, 2024
This was referenced Mar 20, 2024
Closed
Merged
@cuba cuba closed this as completed Apr 4, 2024
@kjozwiak kjozwiak added this to the 1.66.x - Beta milestone Apr 16, 2024
@kjozwiak
Copy link
Member

Adding missing milestone labels as brave/brave-core#22127 (comment) was formatted incorrectly so the automation didn't move the issue into the correct milestone.

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 29, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 30, 2024 •
edited
Loading

Verified on iPhone 12 running iOS 17.3.1 using version 1.66.95

  • Ensured that pre-roll ads are blocked on fresh and upgraded profiles after engines are compiled.
  • Ensured that content ads are blocked.
  • Ensured that ad-blocking works using standard and aggressive ad-blocking.
  • Ensured ads are shown when Shields are disabled in panel.

Encountered: #37962

Shields Up (Top) / Shields Down (Bottom) Shields Up (Top) / Shields Down (Bottom)
IMG_6053 IMG_6054
IMG_6057 IMG_6055

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 30, 2024
@Uni-verse Uni-verse mentioned this issue May 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuba cuba

Labels
enhancement feature/shields/adblock Blocking ads & trackers with Shields OS/iOS Fixes related to iOS browser functionality privacy QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

Unify Adblock engines into 1 engine brave/brave-core
3 participants
@cuba @kjozwiak @Uni-verse