Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel slow to load balance #36693

Open
srirambv opened this issue Feb 1, 2024 · 1 comment
Open

Panel slow to load balance #36693

srirambv opened this issue Feb 1, 2024 · 1 comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA/Yes

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2024

Description:

Wallet panel can be slow to load balance. We should utilize balance cache added in #35986 to load the balance for the selected Dapp account(s) & networks to display the native token balance quickly to avoid long delays when panel is opened (currently more noticeable on panel with wallets utilizing many networks and/or accounts with balance).

Steps to Reproduce

  1. Restore wallet that has balance in Eth testnet
  2. Connect wallet to a Dapp
  3. Open panel, shows balance as 0
  4. Open wallet and select the token from testnet, shows actual balance

Actual result:

Testnet.Balance.MP4

Expected result:

Show balance on panel

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Not checked
  • Can you reproduce this issue with the current build from AppStore? Not checked

Device details:

iPhone 13 (iOS 17.4)

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @nuo-xu @StephenHeaps

@StephenHeaps StephenHeaps changed the title Panel doesn't show balance for Testnet Panel slow to load balance for Testnet Feb 1, 2024
@StephenHeaps
Copy link

Seems like balance fetch is slow here (last frame of video shows balance on the panel). We'll look to see if we can improve this before balance caching lands.
Screenshot 2024-02-01 at 10 23 48 AM

@StephenHeaps StephenHeaps changed the title Panel slow to load balance for Testnet Panel slow to load balance Mar 11, 2024
@StephenHeaps StephenHeaps transferred this issue from brave/brave-ios Mar 11, 2024
@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA/Yes
Projects
Status: Backlog
Development

No branches or pull requests

2 participants