Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet: Persist balance for the rest of wallet other than Portfolio/Assets #36764

Closed
nuo-xu opened this issue Mar 13, 2024 · 1 comment · Fixed by brave/brave-core#24072
Closed

Wallet: Persist balance for the rest of wallet other than Portfolio/Assets #36764

nuo-xu opened this issue Mar 13, 2024 · 1 comment · Fixed by brave/brave-core#24072
Assignees
@nuo-xu
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.69.x - Release

Comments

@nuo-xu
Copy link

nuo-xu commented Mar 13, 2024 •
edited
Loading

We have already persist balances under Portfolio/Assets
We will do the same for other screen currently fetching balance once open:

  1. Portfolio/NFTs
  2. B/S/S fetching token balance
  3. Activity(Transactions)
  4. Accounts
  5. Asset Details
  6. Account Details
  7. Wallet Panel

Each screen can ask for cached balance using AccountInfo, TokenInfo or both directly via WalletUserAssetManager.
No local cache dictionary needed for each view.
Double check unit tests. Might need to update the TestableWalletUserAssetManager to return mock asset/account balances.
@nuo-xu nuo-xu added enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality labels Mar 13, 2024
@StephenHeaps StephenHeaps added the priority/P4 Planned work. We expect to get to it "soon". label Mar 15, 2024
@StephenHeaps StephenHeaps mentioned this issue Apr 17, 2024
Merged
24 tasks
@nuo-xu nuo-xu mentioned this issue Jun 7, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 14, 2024
@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2024

Verification passed on iPhone 13 with iOS 1.69 (162)

  • Verified steps from brave/brave-core#24072
  • Verified balance updates quickly on the following screens
    • Portfolio/NFT
    • Buy/Send/Swap screens
    • Activity screen
    • Account details screen
    • Asset details screen
    • Wallet panel
  • Verified on both clean install and upgrade profile when restoring wallet
  • Encountered #40628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Apply persistent token/account balance for the rest of the wallet brave/brave-core
4 participants
@nuo-xu @StephenHeaps @srirambv @brave-builds