Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Account not prompted if account exists for same coin type on other keyring #37114

Closed
StephenHeaps opened this issue Mar 26, 2024 · 2 comments · Fixed by brave/brave-core#22799
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude

Comments

@StephenHeaps
Copy link

Description:

Network picker does not prompt to create an account for Filecoin testnet/mainnet if an account is created for the opposite network. Ex Filecoin Mainnet account exists, then Filecoin Testnet is selected in network picker (or vice-versa).

Steps to Reproduce

  1. Create a fresh wallet
  2. Enable Show Test Networks in Web3 Settings -> Networks
  3. Add Filecoin Mainnet account
    • Can occur vice-versa too, creating Filecoin Testnet account here then selecting Mainnet in step 5
  4. Open Buy or Swap
  5. Select Filecoin Testnet in network picker
    • If Filecoin Testnet account created, select Filecoin Mainnet in network picker
  6. Observe Filecoin Testnet selected but Filecoin Mainnet

Actual result:

Filecoin Mainnet account selected / Filecoin Testnet network selected

Account.Network.Mismatch.mp4

Expected result:

Prompt to create an account if one does not exist for the network being selected

Reproduces how often:

Easily reproduced

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

Hit testing Bitcoin add account, but same bug exists for Filecoin.

cc @srirambv @nuo-xu

@kjozwiak
Copy link
Member

The above requires 1.64.115 or higher for 1.64.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Apr 8, 2024

Verification passed on iPhone 13 with iOS 17.4.1 running 1.66 (41) Nightly build

  • Verified steps from brave/brave-core#22799
  • Verified when no FIL account created, selecting Buy/Deposit on FIL token details screen both shows account creation message
  • Verified selecting FIL in accounts tab and clicking on Buy/Deposit and selecting FIL Testnet prompts to create an account
Account Screen Asset Screen
37114-Account.Screen.MP4
37114-Asset.Screen.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Archived in project
4 participants