Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet: Optional Bitcoin testnet support via Debug section #37256

Closed
nuo-xu opened this issue Apr 2, 2024 · 1 comment · Fixed by brave/brave-core#22971
Closed

Wallet: Optional Bitcoin testnet support via Debug section #37256

nuo-xu opened this issue Apr 2, 2024 · 1 comment · Fixed by brave/brave-core#22971
Assignees
@nuo-xu
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.66.x - Release

Comments

@nuo-xu
Copy link

nuo-xu commented Apr 2, 2024

due to issue #37192 we will drop bitcoin testnet support in production.
But for testing purpose, we will add a toggle in browser settings debug section for anyone want to use bitcoin testnet network or account to perform any testing. But will experience wrong selected network if switching selected account in between bitcoin mainnet account and bitcoin testnet account.
@nuo-xu nuo-xu added feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality labels Apr 2, 2024
@nuo-xu nuo-xu self-assigned this Apr 2, 2024
@StephenHeaps StephenHeaps mentioned this issue Apr 2, 2024
Merged
24 tasks
@nuo-xu nuo-xu added the QA/Yes label Apr 8, 2024
@nuo-xu nuo-xu mentioned this issue Apr 8, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Apr 10, 2024
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 17.5 running 1.66 (105)

  • Verified steps from brave/brave-core#22971
  • Verified enabling wallet switch in debug section enables Bitcoin Testnet
  • Verified enabling the flag shows Bitcoin Mainnet/Testnet in account creation screen
  • Verified able to filter out Portfolio only on Bitcoin Mainnet/Testnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add a debug option to enable bitcoin testnet brave/brave-core
3 participants
@nuo-xu @srirambv @brave-builds