Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import of BTC zprv extended keys #38446

Closed
Tracked by #32714
supermassive opened this issue May 21, 2024 · 2 comments · Fixed by brave/brave-core#23729
Closed
Tracked by #32714

Support import of BTC zprv extended keys #38446

supermassive opened this issue May 21, 2024 · 2 comments · Fixed by brave/brave-core#23729
Assignees
@supermassive
Labels
feature/web3/wallet/bitcoin feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@supermassive
Copy link

supermassive commented May 21, 2024 •
edited
Loading

Wallet's import account ui should support import of BTC accounts in format of zprv BIP84 extended keys.

https://learnmeabitcoin.com/technical/keys/hd-wallets/derivation-paths/#bip84
@supermassive supermassive added OS/Android Fixes related to Android browser functionality OS/Desktop labels May 21, 2024
@supermassive supermassive self-assigned this May 21, 2024
This was referenced May 21, 2024
Merged
Open
@StephenHeaps StephenHeaps mentioned this issue May 24, 2024
Closed
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label May 27, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 27, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.68.99 Chromium: 126.0.6478.126 (Official Build) beta (64-bit)
Revision 8ccc3a46e66d71dfd21506e1ccb42e08c7d33557
OS Windows 11 Version 23H2 (Build 22631.3737)
  • Verified steps from issue description
  • Verified able to import Bitcoin account via zprv private keys for BIP84 derivation
  • Verified when using xprv or yprv private keys account restore fails
  • Verified when imported m/84'/0'/0'/0/0 is imported as the account address
  • Verified accounts created for 6/12/15/21/24 seed words import via private key works as expected
38446.mp4

@srirambv
Copy link
Contributor

srirambv commented Jul 1, 2024

Verification passed on Google Pixel 8 with Android 14 running 1.68.99 x64 Beta build

  • Verified steps from issue description
  • Verified able to import Bitcoin account via zprv private keys for BIP84 derivation
  • Verified when using xprv or yprv private keys account restore fails
  • Verified when imported m/84'/0'/0'/0/0 is imported as the account address
  • Verified accounts created for 6/12/15/21/24 seed words import via private key works as expected
38446.mp4

@LaurenWags LaurenWags mentioned this issue Jul 22, 2024
Closed
@hffvld hffvld mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/bitcoin feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

Support import of BTC accounts brave/brave-core
3 participants
@supermassive @srirambv @brave-builds