-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Omaha v1.3.361.151 for new users #38597
Labels
Milestone
Comments
This was referenced May 27, 2024
Verification
Windows 11x64Test Case 1: Verify Brave's various Windows installers on a new install.- PASSEDCase 1: Verify correct Omaha updater version installed with Standalone installer - PASSED
Case 2: Verify correct Omaha updater version installed with StandaloneSilent installer - PASSED
Case 3: Verify correct Omaha updater version installed with `Stub installer` - PASSED
Case 4: Verify standalone installer can be installed without admin rights and updater works - PASSED
Case 5: Verify stub installer can be installed without admin rights-PASSED
Test Case 2: Verify Brave's various Windows installers for on demand update- PASSEDVerify correct Omaha updater version installed with Standalone installer for on demand update-PASSED
Verify correct Omaha updater version installed with StandaloneSilent installer for on demand update-PASSED
Verify correct Omaha updater version installed with Stub installer for on demand update - PASSED
Testcase 3 : Background updates via Windows Task Scheduler - PASSEDVerify correct Omaha updater version installed with `Standalone` installer for Background updates - PASSED
Verify correct Omaha updater version installed with `StandaloneSilent` installer for Background updates - PASSED
|
MadhaviSeelam
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Jun 12, 2024
Verification
Windows 11 arm64Test Case 1: Verify Brave's various Windows installers on a new install. - PASSEDCase 1: Verify correct Omaha updater version installed with Standalone installer - PASSED
Case 2: Verify correct Omaha updater version installed with StandaloneSilent installer - PASSED
Case 3: Verify correct Omaha updater version installed with `Stub installer` - PASSED
Case 4: Verify standalone installer can be installed without admin rights and updater works - PASSED
Case 5: Verify stub installer can be installed without admin rights- PASSED
Test Case 2: Verify Brave's various Windows installers for on demand update- PASSEDVerify correct Omaha updater version installed with Standalone installer for on demand update-PASSED
Verify correct Omaha updater version installed with StandaloneSilent installer for on demand update-PASSED
Verify correct Omaha updater version installed with Stub installer for on demand update - PASSED
Testcase 3: Background updates via Windows Task Scheduler - PASSEDVerify correct Omaha updater version installed with `Standalone` installer for Background updates - PASSED
Verify correct Omaha updater version installed with `StandaloneSilent` installer for Background updates - PASSED
|
MadhaviSeelam
added
blocked
QA/Blocked
and removed
blocked
QA/Blocked
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Jun 18, 2024
Verification
|
step 3 | step 4 | step 5 | step 7 | step 8 | step 9 |
---|---|---|---|---|---|
Case 2: Verify correct Omaha updater version installed with StandaloneSilent installer - PASSED
- uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- downloaded and installed
BraveBrowserStandaloneSilentBetaSetup.exe
installer1.68.92
- (https://github.com/brave/brave-browser/releases/download/v1.68.92/BraveBrowserStandaloneSilentBetaSetup.exe) - confirmed 1.68.87 installed successfully (UAC modal is not shown)
- confirmed that the new Omaha updater
1.3.361.151
is shown in the registry path as below as expectedComputer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
- confirmed new Omaha updater version
1.3.361.151
is shown in%LOCALAPPDATA%\BraveSoftware\Update
- opened
brave://settings/help
and confirmed correct version details1.68.92
step 3 | step 4 | step 5 | step 6 |
---|---|---|---|
Case 3: Verify correct Omaha updater version installed with `Stub installer` - PASSED
- uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
- downloaded and installed
BraveBrowserBetaSetup.exe
installer1.68.92
- (https://github.com/brave/brave-browser/releases/download/v1.68.92/BraveBrowserBetaSetup.exe) - confirmed
1.68.92
installed successfully with admin privileges - confirmed that the new Omaha updater
1.3.361.151
is shown in the registry path as below as expectedComputer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
- confirmed new Omaha updater version
1.3.361.151
is shown inC:\Program Files (x86)\BraveSoftware\Update
- confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public released beta version is fetched as expected -
1.68.92
step 4 | step 5 | step 6 |
---|---|---|
Case 4: Verify standalone installer can be installed without admin rights and updater works - PASSED
- Uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- downloaded
BraveBrowserStandaloneBetaSetup.exe
installer for1.68.92
- (https://github.com/brave/brave-browser/releases/download/v1.68.87/BraveBrowserStandaloneBetaSetup.exe) - declined the Admin rights in UAC while installing Brave
- confirmed 1.68.92 installed without admin privileges successfully
- confirmed that the new Omaha updater
1.3.361.151
is shown in the registry path as below as expectedComputer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
- confirmed new Omaha updater version
1.3.361.151
is shown in%LOCALAPPDATA%\BraveSoftware\Update
- open
brave://settings/help
and confirmed latest public version shown -1.68.92
step 3 | step 4 | step 5 | step 6 | step 7 |
---|---|---|---|---|
Case 5: Verify stub installer can be installed without admin rights - PASSED
- uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
- downloaded
BraveBrowserBetaSetup.exe
installer1.68.92
- (https://github.com/brave/brave-browser/releases/download/v1.68.92/BraveBrowserBetaSetup.exe) - declined the admin rights in UAC while installing Brave
- confirmed
1.68.92
installed successfully without admin privileges - confirmed that the new Omaha updater
1.3.361.151
is shown in the registry path as below as expectedComputer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
- confirmed new Omaha updater version
1.3.361.151
is shown in%LOCALAPPDATA%\BraveSoftware\Update
- confirmed stub installer
BraveBrowserBetaSetup.exe
installed Brave successfully and latest public release beta version is fetched -1.68.92
step 4 | step 5 | step 6 | step 7 |
---|---|---|---|
Test Case 2: Verify Brave's various Windows installers for on demand update - PASSED
Verify correct Omaha updater version installed with Standalone installer for on demand update - PASSED
- uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- removed local profile folders from %LOCALAPPDATA%\BraveSoftware
- downloaded and installed previous public beta version
BraveBrowserStandaloneBetaSetup.exe
installer1.68.85
- (https://github.com/brave/brave-browser/releases/download/v1.68.85/BraveBrowserStandaloneBetaSetup.exe) - confirmed
1.68.85
installed successfully with admin privileges - verified Omaha updater version
1.3.361.151
is shown in the registry as expected - verified Omaha updater version
1.3.361.151
is shownC:\Program Files (x86)\BraveSoftware\Update
- go to
brave://settings/help
and wait for update and click on Relaunch - confirmed brave is updated to the latest public beta version
1.68.92
- confirmed Omaha updater version
1.3.361.151
is still shown in the registry as expected - confirmed Omaha updater version
1.3.361.151
is still shownC:\Program Files (x86)\BraveSoftware\Update
step 4 | step 5 | step 6 | step 7 | step 8 | step 9 | step 10 |
---|---|---|---|---|---|---|
Verify correct Omaha updater version installed with StandaloneSilent installer for on demand update - PASSED
- uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- removed local profile folders from %LOCALAPPDATA%\BraveSoftware
- downloaded and installed previous public beta version
BraveBrowserStandaloneSilentBetaSetup.exe
installer1.68.85
- https://github.com/brave/brave-browser/releases/download/v1.68.85/BraveBrowserStandaloneSilentBetaSetup.exe - confirmed
1.68.85
installed - verified Omaha updater version
1.3.361.151
is shown in the registry as expected - verified Omaha updater version
1.3.361.151
is shown%LOCALAPPDATA%\BraveSoftware\Update
- go to
brave://settings/help
and wait for update and click on Relaunch - confirmed brave is updated to the latest public beta version
1.68.87
- confirmed Omaha updater version
1.3.361.151
is still shown in the registry as expected - confirmed Omaha updater version
1.3.361.151
is still shown%LOCALAPPDATA%\BraveSoftware\Update
step 4 | step 5 | step 6 | step 7 | step 8 | step 9 | step 10 |
---|---|---|---|---|---|---|
Verify correct Omaha updater version installed with Stub installer for on demand update - PASSED
- uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- removed local profile folders from %LOCALAPPDATA%\BraveSoftware
- downloaded and installed previous public beta version
BraveBrowserBetaSetup.exe
installer1.68.85
- https://github.com/brave/brave-browser/releases/download/v1.68.85/BraveBrowserBetaSetup.exe - confirmed stub installer for latest public beta release
1.68.92
installed successfully with admin privileges - verified Omaha updater version
1.3.361.151
is shown in the registry as expected - verified Omaha updater version
1.3.361.151
is shown%LOCALAPPDATA%\BraveSoftware\Update
- go to
brave://settings/help
and checked for update - confirmed latest public beta version
1.68.92
is still shown - confirmed Omaha updater version
1.3.361.151
is still shown in the registry as expected - confirmed Omaha updater version
1.3.361.151
is still shownC:\Program Files (x86)\BraveSoftware\Update
step 4 | step 5 | step 6 | step 8 | step 9 | step 10 |
---|---|---|---|---|---|
Test Case 3: Background updates via the Windows Task Scheduler - PASSED
Verify correct Omaha updater version installed with `Standalone` installer for Background updates - PASSED
- uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
- Download an offline (“standalone”) installer for previous non-public version of Brave Beta 1.68.91
- Disconnect from the internet to prevent accidental automatic updates.
- Installed Brave successfully 1.68.91 and close Brave
- Check that the registry value
- BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is
1.3.361.151
.
- BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is
- Connect to the internet.
- Delete the registry value
BraveSoftware\Update\LastChecked
if it exists. - Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
- Check the registry value
BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv
. Verified omaha version still shows1.3.361.151
. - Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2027. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.)
- Open Brave.
- Confirmed Brave updated to latest public version
1.68.92
step 5 | step 6 | step 8 | step 9 | step 10 | step 11 | step 13 |
---|---|---|---|---|---|---|
Verify correct Omaha updater version installed with `StandaloneSilent` installer for Background updates - PASSED
- uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
- Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
- Download an silent (“StandaloneSilent”) installer for previous non-public version of Brave Beta
1.68.91
- Disconnect from the internet to prevent accidental automatic updates.
- Installed Brave successfully
1.68.91
and close Brave - Check that the registry value
- Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is
1.3.361.151
.
- Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is
- Verified
BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap
-beta
- Connect to the internet.
- Delete the registry value
BraveSoftware\Update\LastChecked
if it exists. - Run the “TaskUser” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
- Check the registry value
BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv
. Verified it still shown1.3.361.151
. - Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2027. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.)
- Open Brave.
- Confirmed Brave updated to latest public version
1.68.92
step 5 | step 6 | step 7 | step 10 | step 11 | step 12 | step 14 |
---|---|---|---|---|---|---|
stephendonner
added
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Jun 18, 2024
Not adding |
LaurenWags
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Jun 26, 2024
Verified with below version (and others where indicated):
Verified test plan from brave/brave-core#23842 (comment). Windows 10 x86Test Case 1: Verify Brave's various Windows installers on a new installCase 1: Verify correct Omaha updater version installed with Standalone installer - PASSED
Case 2: Verify correct Omaha updater version installed with StandaloneSilent32 installer - PASSED
Case 3: Verify correct Omaha updater version installed with Stub installer - PASSED
Case 4: Verify standalone (32 bit) installer can be installed without admin rights and updater works - PASSED
Case 5: Verify stub installer can be installed without admin rights - PASSED
Test Case 2: Verify Brave's various Windows installers for on demand updateVerify correct Omaha updater version installed with Standalone (32 bit) installer for on demand update - PASSED
Verify correct Omaha updater version installed with StandaloneSilent (32 bit) installer for on demand update - PASSED
Testcase 3: Background updates via the Windows Task SchedulerVerify correct Omaha updater version installed with Standalone (32 bit) installer for Background updates - PASSED
Verify correct Omaha updater version installed with StandaloneSilent (32-bit) installer for Background updates - PASSED
|
LaurenWags
added
QA Pass-Win64
QA Pass-Win86
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Our automatic update mechanism on Windows is implemented via a fork of Google's "Omaha" technology. Google have released several new versions. We want to pull in those improvements by releasing a new version of our copy of Omaha with the new changes.
Omaha runs as a separate application on users' systems. It gets installed when the user first installs Brave. The goal of this issue is to make Brave's Windows installers install our new version 1.3.361.151 of Omaha. There are no functional changes in the new version of the updater.
After the implementation for this issue has hit Release, we should also install the new Omaha version for existing users. This is captured by #38602.
The text was updated successfully, but these errors were encountered: