Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Chainstack RPC proxy endpoints #38872

Closed
6 tasks done
onyb opened this issue Jun 6, 2024 · 2 comments · Fixed by brave/brave-core#24045
Closed
6 tasks done

Switch to Chainstack RPC proxy endpoints #38872

onyb opened this issue Jun 6, 2024 · 2 comments · Fixed by brave/brave-core#24045

Comments

@onyb
Copy link
Member

onyb commented Jun 6, 2024

Description

We're currently using Infura as our main RPC provider, and the code in brave-core hardcodes this. We'd like to use a generic proxy URL format, which uses Chainstack under the hood. This allows us to easily switch providers whenever we want.

Steps to reproduce

N/A

Actual result

Portfolio balances should load correctly without any console errors. Infura RPCs are used for making requests.

Expected result

Portfolio balances should load correctly without any console errors. Chainstack RPCs are used for making requests.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.66.118

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Ideally uplift this to 1.67.x so we can save on Infura bills. We're currently paying for both Infura as well as Chainstack RPCs.

@kjozwiak
Copy link
Member

The above requires 1.68.92 or higher for 1.68.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.68.92 Chromium: 126.0.6478.71 (Official Build) beta (64-bit)
Revision 393b9968e233540a48f04d74bc4601a05d3a0169
OS Windows 11 Version 23H2 (Build 22631.3737)
  • Verified steps from brave/brave-core#24045
  • Verified balances work as expected on Portfolio
  • Verified no console errors when loading Portfolio balance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants