Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to enable Web Serial #39106

Closed
5 of 6 tasks
robd003 opened this issue Jun 17, 2024 · 2 comments
Closed
5 of 6 tasks

Allow user to enable Web Serial #39106

robd003 opened this issue Jun 17, 2024 · 2 comments
Labels
closed/duplicate Issue has already been reported OS/Desktop

Comments

@robd003
Copy link

robd003 commented Jun 17, 2024

Description

I'd like to use Web Serial to flash my ESP32 devices from the browser. Unfortunately Brave doesn't even give me the option to enable Web Serial.

Steps to reproduce

  1. Navigate to https://esphome.github.io/esp-web-tools/

Actual result

Brave disabled Web Serial and so the user is limited and has to install Chrome (yuck!)

Expected result

Give the user the choice to enable web serial for a domain

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Version 1.67.116 Chromium: 126.0.6478.71 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@robd003
Copy link
Author

robd003 commented Jun 17, 2024

Ideally the way this would work is navigator.serial would be undefined, but when attempted to be accessed the user would be prompted to enable the web serial API. This way there would be no fingerprinting concerns, but the feature could still be enabled when a user needed it.

Brave could treat it just like a request for mic or camera access

@rebron
Copy link
Collaborator

rebron commented Jun 21, 2024

Closing as duplicate of #38791 and fixed in 1.69.x

@rebron rebron closed this as completed Jun 21, 2024
@rebron rebron added the closed/duplicate Issue has already been reported label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants