Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users reporting crashes after daylight savings time in Chile #41028

Open
2 of 6 tasks
hollons opened this issue Sep 12, 2024 · 1 comment
Open
2 of 6 tasks

Users reporting crashes after daylight savings time in Chile #41028

hollons opened this issue Sep 12, 2024 · 1 comment
Labels

Comments

@hollons
Copy link

hollons commented Sep 12, 2024

Description

Daylight savings occurred this past Saturday in Chile. The time change caused Brave to crash for several users (20+ reports) across community and twitter. User's reported that it self resolved after an hour or so, and no longer crashed. Users files likely had the incorrect timestamp during this first hour, which is what caused the crashing to occur.

Steps to reproduce

  1. Only affected users based in Chile when the time change occurred.

Actual result

Brave crashed for the first hour after the time change took place.

Expected result

For Brave not to crash when the time change occurs.

Reproduces how often

No steps to reproduce

Brave version (brave://version info)

1.69.168

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Here's a link to the primary community post used by users to report the issue - https://community.brave.com/t/brave-does-not-launches-even-after-deleting-user-data/567393.

@bsclifton
Copy link
Member

bsclifton commented Sep 23, 2024

I wasn't able to find anything upstream about this - but I'm sure it's an issue in Chromium too.

The time changes are part of a presidential decree from 2022. The Wikipedia page shares time should have advanced 1 hour on first Saturday of September - and then it will fall back 1 hour on first Saturday of April 2025.

Folks reported the issue on September 7th, which is the first Saturday of September. Most people are probably not using the browser at the exact time the change happens (ex: midnight). I'm curious why the clock advancing an hour would cause an issue. It's worth noting that users who hit this condition also tried to create a new profile and that still crashed.

My best guess is that the person's computer didn't receive the time update (ex: didn't have time server set to sync with). And then one of the services we call out to (SKU SDK? update server? unsure) has a timestamp or validates a timestamp. And that check fails. After an hour the issue sorted itself out.

@bsclifton bsclifton added the needs-investigation A bug not 100% confirmed/fixed label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

3 participants