Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lit]: Migrate existing cr_overrides to lit #41098

Closed
fallaciousreasoning opened this issue Sep 17, 2024 · 1 comment · Fixed by brave/brave-core#25600
Closed

[Lit]: Migrate existing cr_overrides to lit #41098

fallaciousreasoning opened this issue Sep 17, 2024 · 1 comment · Fixed by brave/brave-core#25600
Assignees
@fallaciousreasoning
Labels
OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude web-ui
Milestone
1.73.x - Release

Comments

@fallaciousreasoning
Copy link

Chromium is in the process of migrating their cr_elements to Lit, so we should follow suit.

Test Plan

  1. Buttons should still work on Settings page
  2. Toggles should still work on the settings page
@fallaciousreasoning fallaciousreasoning self-assigned this Sep 17, 2024
@fallaciousreasoning fallaciousreasoning mentioned this issue Sep 17, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Sep 17, 2024
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 31, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.72.93 Chromium: 131.0.6778.14 (Official Build) beta (64-bit)
-- | --
Revision | 69e5dc20ca483a13316632df5bcd9279bb2a3cb7
OS | Windows 11 Version 23H2 (Build 22631.4391)
  1. Installed 1.72.93
  2. launched Brave
  3. opened brave://settings and other pages as below

Confirmed buttons and toggles worked as expected in brave://settings pages

brave://settings/getStarted brave://settings/appearance brave://settings/privacy brave://settings/languages brave://settings/system brave://settings/autofill brave://settings/content/automaticDownloads brave://settings/extensions/v2
Image Image Image Image Image Image Image Image
Image Image Image Image Image Image Image Image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude web-ui
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

[CrOverrides]: Migrate existing overrides to Lit brave/brave-core
3 participants
@fallaciousreasoning @brave-builds @MadhaviSeelam