Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim notification is not removed if you claim ad grant via BR panel #4170

Closed
srirambv opened this issue Apr 19, 2019 · 1 comment
Closed

Comments

@srirambv
Copy link
Contributor

Description

Claim notification is not removed if you claim ad grant via BR panel

Steps to Reproduce

  1. Enable rewards
  2. Wait for ads grant notification to show up
  3. Keep rewards page open to see ads payout notification
  4. Claim it via BR panel
  5. Notification doesn't get removed from rewards page
  6. Reload the page, nothing happens
  7. Try to claim the grant via rewards page, shows grant already claimed and removes the notification

Actual result:

Claim notification is not removed if you claim ad grant via BR panel

Expected result:

Notification should be removed immediately after its claimed

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    N/A
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the dev channel?
    Most probably yes
  • Can you reproduce this issue with the nightly channel?
    Most probably yes

Other Additional Information:

Miscellaneous Information:

cc: @jsecretan @ryanml

@ryanml ryanml self-assigned this Apr 22, 2019
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 27, 2019
@tmancey tmancey removed feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels Jan 20, 2020
@tmancey tmancey added the QA/Yes label May 1, 2020
@tmancey tmancey added this to the Dupe / Invalid / Not actionable milestone May 1, 2020
@tmancey
Copy link
Contributor

tmancey commented May 1, 2020

@LaurenWags I have retested and on 1.10 this is working as expected, could you please retest. Thanks

@tmancey tmancey closed this as completed May 1, 2020
@tmancey tmancey removed this from the Dupe / Invalid / Not actionable milestone May 1, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants