Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations for Brave Ads unsupported message #4190

Closed
srirambv opened this issue Apr 22, 2019 · 5 comments
Closed

Missing translations for Brave Ads unsupported message #4190

srirambv opened this issue Apr 22, 2019 · 5 comments
Assignees
Labels
feature/ads l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Missing translations for ads unsupported message

Actual result:

image

Expected result:

All text should be translated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
    Yes- Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Does the issue resolve itself when disabling Brave Rewards?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Miscellaneous Information:

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 26, 2019
@tmancey
Copy link
Contributor

tmancey commented Jul 10, 2019

@anthonypkeane this ticket will need resolving to fix localization issues on the next uplift from brave-core to android

@btlechowski
Copy link

Not reproducible for bg_BG

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

image

@tmancey
Copy link
Contributor

tmancey commented Nov 29, 2019

@srirambv Can you please confirm the above language settings so I can reproduce

@LaurenWags
Copy link
Member

Looks good with the following countries/regions.

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS macOS Version 10.13.6 (Build 17G5019)

Albania/Albanian
Albanian

Hungary/Hungarian
Hungarian

Thailand/Thai
Thai

@srirambv what were your country/language settings for the original issue?

@tmancey tmancey changed the title Missing translations for ads unsupported message Missing translations for Brave Ads unsupported message Jan 20, 2020
@srirambv
Copy link
Contributor Author

Can't check the translations for the region from original issue as ads are available for that region now. Tried setting region to Estonia and language as Kannada for browser but system locale is overriding the text and showing in Estonian. Closing the issue for now as Estonian was also translated

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ads l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

7 participants