Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #41445] Crash when displaying internal pages #42162

Closed
1 of 5 tasks
kylehickinson opened this issue Nov 7, 2024 · 2 comments · Fixed by brave/brave-core#26434
Closed
1 of 5 tasks

[Follow up to #41445] Crash when displaying internal pages #42162

kylehickinson opened this issue Nov 7, 2024 · 2 comments · Fixed by brave/brave-core#26434

Comments

@kylehickinson
Copy link
Collaborator

Description

This crash still is happening in a different way: #41445

There is a crash occurring for some users when loading some internal:// url (ntp, reader mode, http strict mode, etc.), unfortunately we do not know which one is causing it yet (just that its hitting an exception in InternalSchemeHandler.webView(_:start:))

Steps to reproduce

Unknown

Actual result

Crashes

Expected result

Shouldn't Crash

Reproduces how often

Intermittent issue

Brave version

1.70+

Device/iOS version

n/a

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2024

The above requires 1.71.125 or higher for 1.71.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 8, 2024

Verified on iPhone 12 running iOS 18.0 using version 1.71 (125)

  • Ensured that interstitial pages are loading when testing on https://badssl.com.
  • Ensured loading interstitials back to back does not cause any issues.
  • Ensured loading insecure websites will show ...is not secure interstitial.
  • Ensured internal pages can be loaded, ex: brave://version
  • Ensured no issues using Reader mode.
example example example example example example
Image Image Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@kylehickinson @kjozwiak @Uni-verse @brave-builds and others