Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Playlist is missing some system player functionality #42370

Open
3 of 5 tasks
kylehickinson opened this issue Nov 19, 2024 · 1 comment · May be fixed by brave/brave-core#26634
Open
3 of 5 tasks

New Playlist is missing some system player functionality #42370

kylehickinson opened this issue Nov 19, 2024 · 1 comment · May be fixed by brave/brave-core#26634
Assignees
Labels
features/playlist OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/include

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Nov 19, 2024

Description

A couple of pieces are missing from the new playlist for handling input from the system player (what appears on the lock screen):

  • Previous & Next track buttons (◀︎◀︎ & ▶︎▶︎)
  • Changing the playback position via the system progress bar

Steps to reproduce

  1. Start playing an item in Playlist
  2. Bring up system player in one of the many places it will show up: lock screen, control center, dynamic island
  3. Attempt to drag the progress bar to scrub the playlist item
  4. Attempt to play the next or previous track (via AirPods, see comment below)

Actual result

The new playlist UI doesn't support interacting with the system player for these things

Expected result

Should support these options

Reproduces how often

Easily reproduced

Brave version

1.71+

Device/iOS version

N/A

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kylehickinson
Copy link
Collaborator Author

Not sure when this changed but it seems like if you support both the 15s interval seek buttons and the next/previous track buttons only the skip ones show up. Bluetooth buttons still function correctly though to go to the next track, but I dont know how to make iOS show the next/previous buttons at all while also supporting the 15s jumps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features/playlist OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant