Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode - active tab contrast is too low #42751

Closed
1 of 6 tasks
aguscruiz opened this issue Dec 8, 2024 · 5 comments · Fixed by brave/brave-core#26928
Closed
1 of 6 tasks

Dark mode - active tab contrast is too low #42751

aguscruiz opened this issue Dec 8, 2024 · 5 comments · Fixed by brave/brave-core#26928

Comments

@aguscruiz
Copy link

aguscruiz commented Dec 8, 2024

Description

Seeing various threads on reddit about the contrast of active tabs being too low, so I'm making a small tweak to improve the contrast a bit and make it closer to our color theme contrast.

Examples
https://www.reddit.com/r/brave_browser/comments/1h9okcm/looking_for_a_browser_theme_that_is_dark_but/

Contrast details

Current color themes tabbar/active-tab backgrounds (Chromium's default):
Image

Current dark gray themes tabbar/active-tab backgrounds:
Image

New dark gray themes tabbar/active-tab backgrounds:
Image

Actual result

Image

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)


Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@LaurenWags
Copy link
Member

@aguscruiz please add the following required labels as appropriate:

  • QA/Yes or QA/No
  • release-notes/exclude or release-notes/include

cc @kjozwiak

@aguscruiz
Copy link
Author

Added them, sorry @LaurenWags ! cc @rebron in case you want to exclude them from release notes

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 14, 2025

Verification PASSED using

Brave | 1.75.159 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
-- | --
Revision | a7b6f5093a2dad31fc3f56241a7d55be255e69e2
OS | Windows 11 Version 24H2 (Build 26100.2605)

Compared with 1.73.x and confirmed active contrast shown as expected in various themes.

1.73.x | 1.75.x

example example example example example example example example example
Image Image Image Image Image Image Image Image Image
Image Image Image Image Image Image Image Image Image

@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 15, 2025
@NicholasFlamy
Copy link

So I'm not going crazy, this is a recent thing. Well, I might make a feature request for highlighting the current tab in neon red or something because I hate when these anti-UX UI changes happen. (And most of these bad changes are by Google through Chromium.)

@el-pol
Copy link

el-pol commented Feb 8, 2025

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment