Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default search engine dialog needs to have a different title for private windows selection #42990

Closed
1 of 6 tasks
aguscruiz opened this issue Dec 19, 2024 · 1 comment · Fixed by brave/brave-core#27321
Closed
1 of 6 tasks

Default search engine dialog needs to have a different title for private windows selection #42990

aguscruiz opened this issue Dec 19, 2024 · 1 comment · Fixed by brave/brave-core#27321
Assignees
@emerick
Labels
feature/settings needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.76.x - Beta

Comments

@aguscruiz
Copy link

Description

Our dialogs in brave://settings/search have the same title regardless if the user is changing the default search engine or the one for private windows. We should change the title for the private windows one, as suggested in the screenshot below, or something similar.

Steps to reproduce

Actual result

Image

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@bradleyrichter bradleyrichter mentioned this issue Dec 19, 2024
Closed
6 tasks
@rebron rebron added feature/settings needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 8, 2025
@rebron rebron added the QA/Yes label Jan 8, 2025
@rebron rebron assigned emerick and unassigned rebron Jan 22, 2025
@emerick emerick mentioned this issue Jan 22, 2025
Merged
24 tasks
@brave-builds brave-builds added this to the 1.76.x - Nightly milestone Jan 23, 2025
@rebron rebron moved this to Completed in Settings Jan 28, 2025
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.76.52 Chromium: 133.0.6943.54 (Official Build) beta (64-bit)
-- | --
Revision | 5a91fa2d5c8a9f8d2f1bafa26281c840921fc1c2
OS | Windows 11 Version 24H2 (Build 26100.2894)
  1. Installed 1.76.52
  2. launched Brave
  3. opened brave://settings/search
  4. clicked Change for Private window

Confirmed correct title is shown

1.75.x | 1.76.x

Normal window Private window
Image Image
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/settings needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Settings
Status: Completed
Milestone
1.76.x - Beta
Development

Successfully merging a pull request may close this issue.

Rename private search engine settings dialog title brave/brave-core
5 participants
@emerick @rebron @aguscruiz @brave-builds @MadhaviSeelam