Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] RichNTT: CRX component #43359

Closed
5 tasks done
tmancey opened this issue Jan 17, 2025 · 4 comments
Closed
5 tasks done

[ads] RichNTT: CRX component #43359

tmancey opened this issue Jan 17, 2025 · 4 comments
Assignees
@tmancey
Labels
closed/completed Used for META issues or other issues that are not in milestones but have been completed enhancement feature/ads

Comments

@tmancey
Copy link
Contributor

tmancey commented Jan 17, 2025 •
edited
Loading

Description

  • Design new version-able JSON schema
  • Deprecate catalog parsing
  • Migrate database
  • Parse JSON content
  • Persist in database for Rewards users
@tmancey tmancey self-assigned this Jan 17, 2025
@tmancey tmancey added this to Ads Jan 17, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Jan 17, 2025
@tmancey tmancey moved this from New issues to To Do in Ads Jan 17, 2025
@tmancey tmancey moved this from To Do to In progress in Ads Jan 17, 2025
@diracdeltas
Copy link
Member

It should probably be integrity-protected using the work that @boocmp and @bridiver are doing.

@tmancey
Copy link
Contributor Author

tmancey commented Jan 20, 2025 •
edited
Loading

@diracdeltas this uses the same component we already use for regular NTT. @boocmp and @bridiver can you please point me to an GitHub issue, to understand how it may impact us, and any rough timelines if possible? Thanks

@boocmp
Copy link

boocmp commented Jan 26, 2025

If you want to add the verified contents metadata then you need to pass the verifiedContentsKey (it's available in the common script options) to the function that generates the component content then use util.generateVerifiedContents(...) before calling the util.generateCRXFile(...).You can see how it was done for adblock here

@tmancey
Copy link
Contributor Author

tmancey commented Jan 27, 2025

Closed as will be resolved by #43512

@tmancey tmancey closed this as completed Jan 27, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Ads Jan 27, 2025
@tmancey tmancey added the closed/completed Used for META issues or other issues that are not in milestones but have been completed label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
closed/completed Used for META issues or other issues that are not in milestones but have been completed enhancement feature/ads
Projects
Ads
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@diracdeltas @tmancey @boocmp