Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards extension icon does not respond to clicks #4344

Closed
bsclifton opened this issue May 8, 2019 · 2 comments · Fixed by brave/brave-core#2407
Closed

Rewards extension icon does not respond to clicks #4344

bsclifton opened this issue May 8, 2019 · 2 comments · Fixed by brave/brave-core#2407
Assignees
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/include

Comments

@bsclifton
Copy link
Member

bsclifton commented May 8, 2019

Description

When using the browser, a LARGE number of notifications is shown:
Screen Shot 2019-05-08 at 12 29 17 AM

However, clicking the icon does nothing (nothing logged to stdout, or background page, etc)

When inspecting using the task manager, a large % of CPU is being used:
Screen Shot 2019-05-08 at 12 29 37 AM

Steps to Reproduce

Unknown - but @petemill and I both are experiencing this

Reproduces how often:

100% with my profile

Brave version (brave://version info)

Brave 0.67.2 Chromium: 74.0.3729.131 (Official Build) nightly(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? unknown
  • Can you reproduce this issue with the beta channel? unknown
  • Can you reproduce this issue with the dev channel? unknown
  • Can you reproduce this issue with the nightly channel? Y

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N
  • Does the issue resolve itself when disabling Brave Rewards? N
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 8, 2019
@petemill petemill self-assigned this May 9, 2019
@jsecretan jsecretan added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels May 9, 2019
@jsecretan
Copy link

Important to note in this is that it pegs CPU at a 100% when this happens, so actually much worse than it initially seemed.

@bsclifton
Copy link
Member Author

bsclifton commented May 11, 2019

Marked as QA/No because this might be tricky to test

However, @petemill and I both have profiles where this happens and have verified the fix. We can try to share steps to force this to happen (manually editing files) if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants