Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYOM] Expose Host Distiller Scripts on Android #43584

Closed
3 of 6 tasks
jonathansampson opened this issue Jan 29, 2025 · 1 comment · Fixed by brave/brave-core#27390
Closed
3 of 6 tasks

[BYOM] Expose Host Distiller Scripts on Android #43584

jonathansampson opened this issue Jan 29, 2025 · 1 comment · Fixed by brave/brave-core#27390
Assignees
@jonathansampson
Labels
browser-ai OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Milestone
1.77.x - Nightly

Comments

@jonathansampson
Copy link
Contributor

Description

Distiller scripts should be available to Android users.

Steps to reproduce

Expose flag to Android users.

Actual result

Flag not presently exposed to Android users.

Expected result

Feature should be exposed to Android users.

Reproduces how often

Easily reproduced

Brave version

1.74.50 Chromium: 132.0.6834.111 (Official Build) (64-bit)

Device

  • Brand/model: N/A
  • Android version: N/A

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@jonathansampson jonathansampson added browser-ai OS/Android Fixes related to Android browser functionality labels Jan 29, 2025
@jonathansampson jonathansampson self-assigned this Jan 29, 2025
@jonathansampson jonathansampson changed the title [BYOM] Enable Host Distiller Scripts [BYOM] Expose Host Distiller Scripts on Android Jan 29, 2025
@jonathansampson jonathansampson mentioned this issue Jan 29, 2025
Merged
24 tasks
@mattmcalister mattmcalister moved this to Todo in Browser AI Jan 30, 2025
@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 30, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Browser AI Feb 3, 2025
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 3, 2025
@kjozwiak
Copy link
Member

kjozwiak commented Feb 5, 2025

As discussed with @jonathansampson via Slack, QA will also need to run through #40794 while running through the above. Basically ensuring that brave://flags/#brave-ai-host-specific-distillation is enabled by default and ensuring the feature is working as expected using the same STR/Cases mentioned via #40794. CCing @hffvld @Uni-verse @srirambv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathansampson jonathansampson

Labels
browser-ai OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Browser AI
Status: Done
Milestone
1.77.x - Nightly
Development

Successfully merging a pull request may close this issue.

[BYOM] Exposes site-distiller flag to Android users brave/brave-core
4 participants
@mattmcalister @jonathansampson @kjozwiak @brave-builds