Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure on Builder - 'brave/grit/brave_generated_resources.h' file not found #4428

Closed
simonhong opened this issue May 14, 2019 · 1 comment · Fixed by brave/brave-core#2440
Closed

Build failure on Builder - 'brave/grit/brave_generated_resources.h' file not found #4428

simonhong opened this issue May 14, 2019 · 1 comment · Fixed by brave/brave-core#2440
Assignees
@simonhong
Labels
QA/No release-notes/exclude
Milestone
0.67.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented May 14, 2019 •
edited
Loading 

06:43:53  ../../brave/browser/widevine/widevine_utils.cc(10,10):  fatal error: 'brave/grit/brave_generated_resources.h' file not found
06:43:53  #include "brave/grit/brave_generated_resources.h"
06:43:53           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
06:43:53  1 error generated.

cc @bsclifton I saw this error from brave/brave-core#2430
@simonhong simonhong added this to the 0.67.x - Nightly milestone May 14, 2019
@simonhong simonhong self-assigned this May 14, 2019
@simonhong
Copy link
Member Author

simonhong commented May 14, 2019 •
edited
Loading

I think we should generate resource header file as fast as possible because this resource files can be referenced from whole chrome layer.

@simonhong simonhong mentioned this issue May 14, 2019
Merged
28 tasks
@bsclifton bsclifton mentioned this issue May 14, 2019
Merged
28 tasks
This was referenced May 15, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
QA/No release-notes/exclude
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Add missing brave_generated_resources_grit deps brave/brave-core
2 participants
@simonhong @LaurenWags