Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip option on a twitter thread takes time to show up #4558

Closed
srirambv opened this issue May 23, 2019 · 4 comments
Closed

Tip option on a twitter thread takes time to show up #4558

srirambv opened this issue May 23, 2019 · 4 comments

Comments

@srirambv
Copy link
Contributor

Description

Tip option on a twitter thread takes time to show up

Steps to Reproduce

  1. Open a tweet which has a good number of replies
  2. Tip option doesn't show up for a good 3-4 secs

Actual result:

Tip option on a twitter thread takes time to show up. The lag is pretty noticeable

Expected result:

Tip option should show up when a tweet thread is opened

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.67.55 Chromium: 75.0.3770.38 (Official Build)nightly (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @alexwykoff @mandar-brave @jenn-rhim

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks feature/rewards QA/Yes release-notes/exclude labels May 23, 2019
@NejcZdovc
Copy link
Contributor

this is intentional as we have timer to do it every 3s

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone May 27, 2019
@kjozwiak kjozwiak removed this from the Dupe / Invalid / Not actionable milestone May 28, 2019
@kjozwiak
Copy link
Member

kjozwiak commented May 28, 2019

this is intentional as we have timer to do it every 3s

@NejcZdovc regarding the above, does this mean Twitter in general? Or just Twitter threads? Assuming threads as the tip buttons are loaded instantly when you visit Twitter. Just out of curiosity, what's the reasoning for waiting 3s for the tip button to appear when viewing threads? Makes it seem a bit janky.

@NejcZdovc
Copy link
Contributor

@kjozwiak more info here brave/brave-core#2195 (comment)

@kjozwiak
Copy link
Member

@NejcZdovc thanks 👍

@NejcZdovc NejcZdovc removed the polish Nice to have — usually related to front-end/visual tasks label May 28, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants