Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to 'Always show bookmarks bar on New Tab Page' #4782

Closed
rebron opened this issue Jun 10, 2019 · 5 comments · Fixed by brave/brave-core#2869
Closed

Add setting to 'Always show bookmarks bar on New Tab Page' #4782

rebron opened this issue Jun 10, 2019 · 5 comments · Fixed by brave/brave-core#2869

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 10, 2019

Test plan

See brave/brave-core#2869

Description

Some users only want to see the bookmarks bar on the New Tab page and nowhere else. We need to create a preference to support this behavior. On by default -> #5781

This is a follow up to this issue: #1306 (comment) that supports the View "Always Show Bookmarks Bar" setting on every window including the New Tab page.

Design

Screen Shot 2019-08-26 at 1 22 11 PM

@simonhong
Copy link
Member

@rebron I set milestone as 0.68.x nightly because #1306 is merged into 0.68.x. I assume that many users will say about this if don't have a fix this this.

@simonhong simonhong self-assigned this Jun 12, 2019
@rebron
Copy link
Collaborator Author

rebron commented Jun 13, 2019

cc: @petemill may have suggestions on how this should look (where setting should go).

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 21, 2019
@rebron rebron removed this from the 0.68.x - Beta milestone Aug 13, 2019
@rebron
Copy link
Collaborator Author

rebron commented Aug 19, 2019

Can we check that with this fix, on Windows 10, bookmarks bar shows up in full screen mode?
cc: @Brave-Matt

@Brave-Matt
Copy link

Brave-Matt commented Aug 19, 2019

Bookmarks bar spacing issue in Fullscreen mode looks like this:
image

As opposed to:
image

Occurs on Release (67.125 - nightly). User reporting same behavior:
https://www.reddit.com/r/brave_browser/comments/csix6u/bookmarks_on_new_tab_page_dont_align_well_in_full/

@srirambv
Copy link
Contributor

srirambv commented Sep 3, 2019

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Verified steps from brave/brave-core#2869
Always show bookmarks bar on New Tab page is on by default.

Verified passed with

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

@rebron rebron changed the title Show bookmarks bar on New Tab Page only Add setting to 'Always show bookmarks bar on New Tab Page' Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment