Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update paper buttons to spec #4852

Closed
rossmoody opened this issue Jun 12, 2019 · 1 comment · Fixed by brave/brave-core#2778
Closed

Update paper buttons to spec #4852

rossmoody opened this issue Jun 12, 2019 · 1 comment · Fixed by brave/brave-core#2778
Assignees
@rossmoody
Labels
polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@rossmoody
Copy link
Contributor

Related: #3633

Full button spec can be found here: https://share.goabstract.com/22f7c7af-fa47-404f-aeca-b896f0c58b4b

image
@rossmoody rossmoody added the polish Nice to have — usually related to front-end/visual tasks label Jun 12, 2019
@rossmoody rossmoody self-assigned this Jun 12, 2019
@rossmoody rossmoody mentioned this issue Jun 12, 2019
Closed
@rossmoody rossmoody mentioned this issue Jun 25, 2019
Merged
@rebron rebron added this to the 0.69.x - Dev milestone Aug 7, 2019
This was referenced Aug 22, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 29, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed with

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux
  • Verified button behaviour matches as per test plan
  • Verified both using mouse and keyboard tab to verify the button behaviour

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Button styles brave/brave-core
Paper button styles brave/brave-core
5 participants
@rebron @srirambv @LaurenWags @rossmoody @btlechowski