Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ads earnings notification partially translated #4861

Closed
btlechowski opened this issue Jun 12, 2019 · 4 comments
Closed

ads earnings notification partially translated #4861

btlechowski opened this issue Jun 12, 2019 · 4 comments

Comments

@btlechowski
Copy link

btlechowski commented Jun 12, 2019

Steps to Reproduce

  1. Change language to Norwegian
  2. Show ads earnings notification

Note: also reproducible for German
TODO: check other languages.

Actual result:

Your earnings from ads are available. is not translated
image

image

German:
image

Expected result:

Your earnings from ads are available. is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Verification passed on

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta (64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Windows 7 Service Pack 1 (Build 7601.24465)

cc @bsclifton @brave/legacy_qa

@tmancey
Copy link
Contributor

tmancey commented Jul 10, 2019

@anthonypkeane this ticket will need resolving to fix localization issues on the next uplift from brave-core to android

@rebron
Copy link
Collaborator

rebron commented Jul 11, 2019

@NejcZdovc We're not seeing this string in transifex to be localized.

@btlechowski
Copy link
Author

No longer reproducible on

Brave 1.2.11 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

image
image

@btlechowski btlechowski added this to the 1.2.x - Dev milestone Nov 27, 2019
@btlechowski
Copy link
Author

btlechowski commented Nov 28, 2019

Verified passed with

Brave 1.2.11 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified test plan from the description.
German language:
image
image

Verified passed with

Brave 1.2.23 Chromium: 79.0.3945.70 (Official Build) beta (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description for Norwegian and German
    Norwegian:

Norwegian banner

Norwegian Panel

German:
German banner
German panel

Verification passed on

Brave 1.2.35 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description for Norwegian and German
    Norwegian:
    image
    image
    Germany:
    image
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants