Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In windows 8.1 Brave ads notification popup has chrome favicon instead of brave #5008

Closed
GeetaSarvadnya opened this issue Jun 21, 2019 · 2 comments · Fixed by brave/brave-core#2963

Comments

@GeetaSarvadnya
Copy link

Description

Brave ads notification popup has chrome favicon instead of brave

Steps to Reproduce

  1. Clean profile 0.65.120
  2. View ad ad
  3. Verify the ads notification popup

Actual result:

Brave ads notification popup has chrome favicon instead of brave
image (1)

Expected result:

Ads notification should have Brave favicon

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Windows 8.1 (Build 9600.19377)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa @tmancey

@LaurenWags
Copy link
Member

I reproduced this when looking at some Ads stuff on Win 10 x64 today. Nightly versions 0.68.39 and 0.69.7.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 5, 2019
@jsecretan jsecretan added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 17, 2019
@kjozwiak kjozwiak added this to the 0.69.x - Nightly milestone Jul 22, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Aug 29, 2019

Verified passed with macOS 10.13.6 x64 using

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified Brave logo is displayed on both native and non-native notifications:

Screen Shot 2019-08-29 at 5 07 51 PM

Screen Shot 2019-08-29 at 5 09 26 PM

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revisionfd 1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OSW indows 8.1 (Build 9600.19401)
  • Verified Brave logo is displayed on ads notifications:
    image

image

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants