Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payment balances not called after first run of application #5046

Closed
tmancey opened this issue Jun 26, 2019 · 1 comment · Fixed by brave/brave-core#2807
Closed

Fix payment balances not called after first run of application #5046

tmancey opened this issue Jun 26, 2019 · 1 comment · Fixed by brave/brave-core#2807

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 26, 2019

Description

Fix payment balances not called after first run of application

Steps to Reproduce

  1. Fresh install
  2. Launch app
  3. Search console log for GetPaymentBalance (which should exist)
  4. Quit app
  5. Launch app
  6. Search console log for GetPaymentBalance

Actual result:

GetPaymentBalance does not exist

Expected result:

GetPaymentBalance should exist

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.68.2

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@srirambv
Copy link
Contributor

srirambv commented Jun 28, 2019

Verification passed on

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux
  • Verified OnGetPaymentBalance is logged on a clean profile
    image
  • Verified quitting browser and relaunching still logs OnGetPaymentBalance

Verified passed with

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X
  • Verified STR from description

Verification passed on

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified GetPaymentBalance is logged on a clean profile
    image
  • Verified quitting browser and relaunching still logs GetPaymentBalance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants