Browser crash when changing shields settings

[srirambv]

Browser crash when changing shields settings

1. Visit http://cartoonhd.zone (used this because it detects adblockers)
2. Enable FP and Block Phishing from shields
3. Watch some video
4. Open shields, FP and Block phishing was disabled, tried enabling again and browser crashed

Note: You might have to watch couple of videos for the adblocker to be detected on the site and show up anti-adblocker message

[bbondy]

@srirambv fixed?

[srirambv]

Yes looks fixed. No crash on shields settings toggle.

[GeetaSarvadnya]

Validated the issue on:

Brave	0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision	9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS	Windows
JavaScript	V8 6.9.427.14
Flash	30.0.0.154

Verification Passed on

Brave	0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Linux

Verification Pass with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X