Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update profile manager menu #5213

Closed
rebron opened this issue Jul 11, 2019 · 4 comments · Fixed by brave/brave-core#3292
Closed

update profile manager menu #5213

rebron opened this issue Jul 11, 2019 · 4 comments · Fixed by brave/brave-core#3292

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 11, 2019

Description

Update profile manager menu.

  1. Remove Passwords, Payment methods, Addresses and more
    2) Add 'Create New Profile' -> creates new profile and launches into brave://welcome Profile Avatar Menu: Add 'Create New Profile'  #5834
  2. Replace 'Manage People' label with 'Manage Profiles'
  3. Remove 'Open Tor Window'

Test plan

Changes should match the AFTER picture (picture on the right, baby steps new menu)
image

@rebron rebron added feature/profile-manager priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 11, 2019
@petemill
Copy link
Member

petemill commented Aug 28, 2019

  • Remove Passwords, Payment methods, Addresses and more
  • Add 'Create New Profile' -> creates new profile and launches into brave://welcome
  • Replace 'Manage People' label with 'Manage Profiles'
  • Remove 'Open Tor Window'

@petemill
Copy link
Member

@rebron Right now it's difficult to add 'Create New Profile' item without patching chromium quite a bit. However, in the next version of chromium which we'll be rebasing on, the code is much nicer to insert an item in to. So let's separate that in to a different issue. Everything else is catered for in brave/brave-core#3292

@rebron
Copy link
Collaborator Author

rebron commented Aug 29, 2019

@petemill Let's add it back when it's easier to insert.

@btlechowski
Copy link

btlechowski commented Oct 8, 2019

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified test plan from the description.

Before upgrade from 0.69.132
image
After Upgrade to 0.70.x
image

Verified passed with

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified items from description
    Menu in 0.69.132:

Screen Shot 2019-10-09 at 11 39 55 AM

Menu after upgrading to 0.70.111:
Screen Shot 2019-10-09 at 11 40 48 AM

Verification passed on

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified items from description
    Menu in 0.69.132:
    image

Menu after upgrading to 0.70.111:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants