Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request user confirmation before opening all external applications #542

Closed
jumde opened this issue Jul 13, 2018 · 3 comments · Fixed by brave/brave-core#776
Closed

Request user confirmation before opening all external applications #542

jumde opened this issue Jul 13, 2018 · 3 comments · Fixed by brave/brave-core#776
Assignees
@jumde
Labels
priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/include security
Milestone
0.59.x - Release ...

Comments

@jumde
Copy link
Contributor

jumde commented Jul 13, 2018

STR:

  • Load:
<script>
  document.location = 'mailto://test@test.com';
</script>
@jumde
Copy link
Contributor Author

jumde commented Jul 13, 2018

Works for news: protocol as well

@bbondy bbondy added this to the Backlog milestone Jul 16, 2018
@jumde jumde mentioned this issue Sep 18, 2018
Closed
@diracdeltas diracdeltas modified the milestones: 1.x Backlog, 1.0 Oct 29, 2018
@diracdeltas diracdeltas added release/blocking priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 29, 2018
@diracdeltas diracdeltas changed the title Request user confirmation before opening external applications Request user confirmation before opening all external applications Oct 29, 2018
@jumde jumde self-assigned this Oct 29, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@jumde jumde mentioned this issue Oct 31, 2018
Merged
18 tasks
@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 29, 2018
@bbondy
Copy link
Member

bbondy commented Nov 29, 2018

Please update milestone where things are merged to for next one.

@srirambv
Copy link
Contributor

srirambv commented Jan 2, 2019 •
edited by btlechowski
Loading

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

image

Verified passed with macOS x64 10.12.6

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X
  • Created html file from description
  • Tried to open file with release version 0.58.18 and saw Mail app was opened without confirmation prompt:
    screen shot 2019-01-02 at 3 26 26 pm
  • Attempted to open file with beta version 0.59.14 and received confirmation prompt:
    screen shot 2019-01-02 at 3 26 55 pm
  • Verified 'Open Mail' button closes prompt and opens Mail app. Cancel closes prompt and Mail app is not opened.

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

image

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
@Kingcrypto38 Kingcrypto38 mentioned this issue Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/include security
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Issue 542: Request user confirmation before opening all external applications brave/brave-core
7 participants
@diracdeltas @tildelowengrimm @bbondy @jumde @srirambv @LaurenWags @btlechowski