Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension name not in dialog box - follow up to 3231 #5575

Open
LaurenWags opened this issue Aug 7, 2019 · 1 comment
Open

Extension name not in dialog box - follow up to 3231 #5575

LaurenWags opened this issue Aug 7, 2019 · 1 comment
Labels

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #3231

When trying to add an extension, the extension name isn't in the dialog box:
google

Steps to Reproduce

  1. Go to https://chrome.google.com/webstore/category/extensions
  2. Click on any extension (I used Google Translate - https://chrome.google.com/webstore/detail/google-translate/aapbdbdomjkkjkaonfhkkikfgjllcleb
  3. Click Add to Chrome

Actual result:

Warning text displays, but name of extension does not.

Expected result:

Question asking if you'd like to add "Extension Name":

Add " to Brave?

See design from #3231

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? unsure
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @rebron @tomlowenthal @karenkliu

@btlechowski
Copy link

Reproduced on Ubuntu

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: P3 backlog
Development

No branches or pull requests

2 participants