Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key for brave services #5690

Closed
jumde opened this issue Aug 16, 2019 · 3 comments · Fixed by brave/brave-core#3198
Closed

Add key for brave services #5690

jumde opened this issue Aug 16, 2019 · 3 comments · Fixed by brave/brave-core#3198

Comments

@jumde
Copy link
Contributor

jumde commented Aug 16, 2019

Description

Requests to brave services will use the brave services key

@jumde jumde self-assigned this Aug 16, 2019
@jumde jumde changed the title Add keys for brave services Add key for brave services Aug 16, 2019
@jumde jumde added this to the 0.73.x - Nightly milestone Oct 17, 2019
@kjozwiak
Copy link
Member

@jumde assuming this should be labelled as QA/Yes as there's a test case outlined in brave/brave-core#3198 (comment)?

@jumde jumde added the QA/Yes label Oct 30, 2019
@jumde
Copy link
Contributor Author

jumde commented Oct 30, 2019

Updated the label @kjozwiak

@btlechowski
Copy link

btlechowski commented Nov 22, 2019

Verified passed with

Brave 1.2.8 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3198
Verified BraveServiceKey for following domains
https://static1.brave.com
image
https://crlsets.brave.com
image
https://crlsets.brave.com en-us-8-0.bdic - does not have BraveServiceKey
image
https://laptop-updates.brave.com - does not have it
image
https://static.brave.com
image
https://go-updater.brave.com
image
https://componentupdater.brave.com
image
https://brave-core-ext.s3.brave.com
image
https://p3a.brave.com
image
https://safebrowsing.brave.com
image
https://ads-serve.brave.com - does not have it
image
Logged #7062

Verification passed on

Brave 1.2.37 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

https://static.brave.com
image

https://crlsets.brave.com
image

https://go-updater.brave.com
image

https://componentupdater.brave.com
image

https://safebrowsing.brave.com
image

https://brave-core-ext.s3.brave.com
image

  • Verified brave service requests will use BraveServiceKey in an upgraded profile

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.2.40 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.15.2 (Build 19C57)
JavaScript V8 7.9.317.32

https://static.brave.com

Screen Shot 2020-01-02 at 7 08 56 PM

Screen Shot 2020-01-02 at 7 09 05 PM

Screen Shot 2020-01-02 at 7 09 15 PM

https://go-updater.brave.com

Screen Shot 2020-01-02 at 7 08 37 PM

https://componentupdater.brave.com

Screen Shot 2020-01-02 at 7 07 58 PM

Screen Shot 2020-01-02 at 7 08 05 PM

Screen Shot 2020-01-02 at 7 07 58 PM

https://brave-core-ext.s3.brave.com

Screen Shot 2020-01-02 at 7 06 53 PM

Screen Shot 2020-01-02 at 7 07 13 PM

Screen Shot 2020-01-02 at 7 07 23 PM

Screen Shot 2020-01-02 at 7 07 33 PM

https://static1.brave.com

Screen Shot 2020-01-02 at 7 05 37 PM

Screen Shot 2020-01-02 at 7 05 46 PM

https://safebrowsing.brave.com

Screen Shot 2020-01-02 at 7 05 04 PM

https://p3a.brave.com

Screen Shot 2020-01-02 at 7 04 43 PM

https://crlsets.brave.com

Screen Shot 2020-01-02 at 6 54 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment