Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "Person X" default profile name to "Profile X" for all languages #5814

Closed
petemill opened this issue Aug 27, 2019 · 1 comment · Fixed by brave/brave-core#3265
Closed

Comments

@petemill
Copy link
Member

petemill commented Aug 27, 2019

Description

Related to #5789 (generate new profiles with "Profile X" name instead of "Person X")
Related to #5665 (rename instances of "People"/"Person" to "Profile"

Test plan / Steps to Reproduce

  1. With a previous version of Brave
  2. Create a new profile
  3. Observe that first and new profile are created in the format "Person X" (in the user's language)
  4. Quit Brave
  5. Open the version of Brave with a fix for this issue, against that user directory used in the previous steps.
  6. Open Profiles menu in Toolbar
    ---> Observe that all profiles are now in the format "Profile X"
@btlechowski
Copy link

btlechowski commented Oct 8, 2019

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified that Person x is renamed to Profile x
Before upgrade from 0.69.132
image
After Upgrade to 0.70.x
image

Verified that profiles with custom name are not renamed

Logged #6345

Verification passed on

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Using 0.69.132
Screen Shot 2019-10-09 at 5 46 20 PM

After Upgrade to 0.70.x
Screen Shot 2019-10-09 at 5 46 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment