-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove twitter panel support #5828
Comments
Closing this as I was able to reproduce twitter mismatch without ever utilizing (opening) the panel. I followed the steps in #5580 and tipped verified and unverified twitter users entirely with in-line tipping and was still able to reproduce a mis-match. Attempting to tip twitter.com/brave looks like it resulted in a tip to twitter.com/bravelaurenwags instead: However, upon further inspection, (looking at the pending table), the tip appears to have gone to a 3rd (different) user entirely - the URL at the bottom highlighted in the purple box does NOT match the user in the red box: |
cc @rebron @kjozwiak @NejcZdovc Happy to provide further information if needed. |
Awesome work @LaurenWags 👍 Thanks for investigating! Looks like we'll need to basically fix Twitter tipping as it's completely broken right now as @LaurenWags proved above. @rebron @davidtemkin @NejcZdovc @bsclifton we'll need to fix #5580 to get Twitter into a working state. |
Description
Due to #5580 we discussed removing panel support if that issue cannot be resolved in time for 0.69.x release.
This is to track that discussion.
Miscellaneous Information:
@kjozwiak and @LaurenWags to verify that tipping only via in-line tip button (not using the panel at all) does not result in mismatch/tipping incorrect twitter user.
Placed this into 0.69.x milestone per discussion with @rebron - please move out if necessary.
The text was updated successfully, but these errors were encountered: