Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove twitter panel support #5828

Closed
LaurenWags opened this issue Aug 28, 2019 · 4 comments
Closed

remove twitter panel support #5828

LaurenWags opened this issue Aug 28, 2019 · 4 comments

Comments

@LaurenWags
Copy link
Member

Description

Due to #5580 we discussed removing panel support if that issue cannot be resolved in time for 0.69.x release.

This is to track that discussion.

Miscellaneous Information:

@kjozwiak and @LaurenWags to verify that tipping only via in-line tip button (not using the panel at all) does not result in mismatch/tipping incorrect twitter user.

Placed this into 0.69.x milestone per discussion with @rebron - please move out if necessary.

@LaurenWags LaurenWags added this to the 0.69.x - Beta milestone Aug 28, 2019
@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 29, 2019

Closing this as I was able to reproduce twitter mismatch without ever utilizing (opening) the panel. I followed the steps in #5580 and tipped verified and unverified twitter users entirely with in-line tipping and was still able to reproduce a mis-match.

Attempting to tip twitter.com/brave looks like it resulted in a tip to twitter.com/bravelaurenwags instead:

Screen Shot 2019-08-29 at 12 13 36 PM

Screen Shot 2019-08-29 at 12 13 42 PM

However, upon further inspection, (looking at the pending table), the tip appears to have gone to a 3rd (different) user entirely - the URL at the bottom highlighted in the purple box does NOT match the user in the red box:
Screen Shot 2019-08-29 at 12 20 54 PM

@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 29, 2019

cc @rebron @kjozwiak @NejcZdovc

Happy to provide further information if needed.

@LaurenWags LaurenWags removed QA/Yes feature/rewards needs-investigation A bug not 100% confirmed/fixed labels Aug 29, 2019
@LaurenWags LaurenWags removed this from the 0.69.x - Beta milestone Aug 29, 2019
@LaurenWags
Copy link
Member Author

Per request, I also checked this without using in-line tips and ONLY tipped via panel. Still received mismatch:

  1. Clean profile on 0.69.x

  2. Enable Rewards

  3. Navigate to twitter.com and login

  4. Navigate to a page, tip thru panel. (user was unverified, not sure if this matters)

  5. Navigate to another twitter page.

  6. Open panel --> see mismatch on panel, shows previous user info.
    Screen Shot 2019-08-29 at 1 12 10 PM

  7. Ignore and click on send tip anyway.

  8. Tip banner opens --> still mismatch. URL says kamiljozwiak but banner says different user.
    Screen Shot 2019-08-29 at 1 09 05 PM

@kjozwiak
Copy link
Member

kjozwiak commented Sep 2, 2019

Awesome work @LaurenWags 👍 Thanks for investigating! Looks like we'll need to basically fix Twitter tipping as it's completely broken right now as @LaurenWags proved above.

@rebron @davidtemkin @NejcZdovc @bsclifton we'll need to fix #5580 to get Twitter into a working state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants