unable to tip more than 100 BAT

[LaurenWags]

Description

While testing user wallets I noticed that there's a notification on the Uphold authorization screen which says you will need to reauthorize once you have 100 BAT in transactions. After tipping 100 BAT to various verified/KYC'd publishers (so that the BAT left my wallet), when I tried to tip over the 100 BAT, I was not forced to reauthorize. I just got the generic tip error message.

Steps to Reproduce

1. Clean install, enable rewards, connect KYC'd account
2. If account doesn't have at least 100 BAT in Brave Browser card, add it.
3. Tip sites until I've tipped 100 BAT to various sites.
4. Try to tip again.

Actual result:

Expected result:

Expected to be disconnected (green Verified would changed to gray Disconnected button) and notification about the wallet being unreachable would be displayed.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision	fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS	Mac OS X

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the dev channel? unsure
• Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Per discussion with @mandar-brave the limit was supposed to be increased. Possibly that didn't happen. Also, here's the uphold screen which mentions the 100 BAT limit:

[LaurenWags]

Note - this also happens with the following STR:

1. Clean install, enable rewards, connect KYC'd account
2. If account doesn't have at least 100 BAT in Brave Browser card, add it.
3. Set monthly budget to 100 BAT. Visit only verified, KYC'd publishers.
4. Let contribution go thru.
5. Now try to tip a site.

[LaurenWags]

When this is fixed, will need to check that you actually get put in Disconnected state once you hit the transaction limit because right now there are errors when trying to do over 100 BAT in transactions.

[NejcZdovc]

@mandar-brave what should we do?

[mandar-brave]

@NejcZdovc even if we hit Uphold limits, we need to ask user to re-auth and reset the token with a fresh 100 BAT. By failing and no re-authing;
a) we can't retry the current transaction
b) we will fail on every future transaction

Do we not get a clear error when we hit the limits.

[NejcZdovc]

I mean not sure how re-auth would work if limit for one time is 100. So if user want's to do 150 will Uphold even allow it?

[mandar-brave]

@NejcZdovc re-authing token resets value to allow new set of transactions up to 100.
Uphold is moving default ceiling to 250 BAT which will help.

Uphold setting for token expiry now is > 250 BAT transactions or 2 months, whichever comes first. At that point user has to re-auth to get token expiry reset.

[NejcZdovc]

@mandar-brave yes I am aware of that, what I am saying if user want's to tip 500 BAT this will not go through no re-auth will work as limit is max to 250. We need to limit tip amounts on publisher side to match uphold amounts so user will not be put in this situation

[mandar-brave]

Fair! we will have to cap Creator max to 250 BAT for the moment!

[marshall]

duplicate of #3718