Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed shown as empty block w/o message #5959

Closed
tjcrowder opened this issue Sep 10, 2019 · 2 comments
Closed

Embed shown as empty block w/o message #5959

tjcrowder opened this issue Sep 10, 2019 · 2 comments
Labels
feature/shields The overall Shields feature in Brave.

Comments

@tjcrowder
Copy link

Description

I'm not sure if this is a bug or just an effect of using Shields. Going to this page, the CodeSandBox.io embeds under "Success" near the end of the article show as blank dark grey boxes in Brave. (If you have DNT turned on, you have to click a Show Embed button first.) They work correctly in Chrome and Firefox.

Apologies in advance if this is just an expected effect of using Shields.

Steps to Reproduce

  1. Go to https://medium.com/@jasvir/monoglots-when-a-subset-is-not-1604e3a51d9
  2. Scroll down to the "Success" section
  3. If the embeds are showing a DNT message, click the Show Embed button

Actual result:

You get dark grey boxes rather than the CodeSandBox.io embeds.

Expected result:

Seeing the CodeSandBox.io embeds.

Reproduces how often:

Every time.

Brave version (brave://version info)

Brave: 0.68.132 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision: fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS: Linux

Version/Channel Information:

Sorry, I can't try other channels/releases at the moment.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?

Yes.

  • Does the issue resolve itself when disabling Brave Rewards?

Didn't try it, looks like a Shields issue (or just an effect of using Shields).

  • Is the issue reproducible on the latest version of Chrome?

No

@rebron rebron added the feature/shields The overall Shields feature in Brave. label Sep 27, 2019
@rebron
Copy link
Collaborator

rebron commented Sep 27, 2019

@tjcrowder Not able to reproduce on 72.x which is Nightly channel with Shields up. Do you have your global shield settings set to block all cookies or block all for device recognition?

@tjcrowder
Copy link
Author

@rebron - I can't replicate it any more with Brave Version 0.68.140 Chromium: 77.0.3865.90, so figure it got fixed. :-)

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave.
Projects
None yet
Development

No branches or pull requests

3 participants