History uses Chromium bookmark icon (star) for bookmark entries

[srirambv]

Description

History uses Chromium bookmark icon for bookmark entries

Steps to Reproduce

1. Visit any site and bookmark
2. Open Hisory
3. Shows Chromium bookmark icon instead of Brave bookmark icon

Actual result:

Expected result:

Use Brave branding icons everywhere

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.68.132 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision	fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS	Linux

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[bsclifton]

@srirambv can you be more specific about what is wrong? When I look at the picture shown, it looks good to me (shows picture of Brave icon).

[srirambv]

@bsclifton the icon on right is chromium star we replaced the bookmark icon with our custom icon which should be used.

[karenkliu]

@srirambv I don't see the star? This is what my bookmarks looks like:

Version 1.4.16 Chromium: 79.0.3945.74 (Official Build) nightly (64-bit)

The bigger issue for me is we should be using our own bookmarks folder icon:

It replaces the Chrome bookmarks folder icon in the browser toolbar and on chrome://bookmarks/

Please use our Brave folder icon:
bookmark folder icon.zip
(Maybe this should be a separate issue though)

[srirambv]

@karenkliu need to check the entry in history(brave://history). If the site is bookmarked it shows the star next to it as shown in issue.

[rebron]

another example but in dark mode

[karenkliu]

oh got it - okay, you're saying it should look like this?

Here you go:
fill-bookmarked.zip
Let's make it 16x16 large.

[darrylbutcher]

Looks like the fix would be creating a patch on this file in the chromium source. If theres some documentation on how you create your chromium patches/how to validate and test them I can give it a shot

[bsclifton]

Hi @darrylbutcher - our wiki has some good information about getting setup:
https://github.com/brave/brave-browser/wiki

We do have a specific section about patching too:
https://github.com/brave/brave-browser/wiki/Patching-Chromium

This might be as easy as creating a new file under chromium_src (matching directory structure of existing icon)

[karenkliu]

I don't see this issue anymore - now I only see the kebab icon, no bookmark icon:

Should we close this issue?

[bsclifton]

@karenkliu you need to have the site bookmarked for it to show

[karenkliu]

@bsclifton The sites in the above screenshot are all bookmarked? 🤷