Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://welcome jank when resizing (specifically dark mode) #6183

Closed
kjozwiak opened this issue Sep 26, 2019 · 1 comment · Fixed by brave/brave-core#3529
Closed

brave://welcome jank when resizing (specifically dark mode) #6183

kjozwiak opened this issue Sep 26, 2019 · 1 comment · Fixed by brave/brave-core#3529

Comments

@kjozwiak
Copy link
Member

Description

When resizing the brave://welcome page, you'll notice that it's pretty janky/sluggish. Easily noticeable when using the dark theme. Sometimes it will also leave a light border at the bottom as the screen doesn't full repaint when it's resized quickly.

Steps to Reproduce

  1. launch 0.69.129 CR: 77.0.3865.90 (make sure you're using dark theme)
  2. open brave://welcome and start resizing the window

Actual result:

welcomeJanky

Expected result:

Resizing brave://welcome shouldn't be this janky/sluggish and should finish repainting the entire window once resized.

Reproduces how often:

100% reproducible when using the above STR.

Brave version (brave://version info)

Brave 0.72.53 Chromium: 77.0.3865.90 (Official Build) nightly (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
JavaScript V8 7.7.299.11

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A (hasn't been released yet)
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa

@btlechowski
Copy link

btlechowski commented Oct 9, 2019

Verification passed on

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified test plan from the description
6183

Verification passed on

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description

Verified passed with

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment