Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reset state business logic to be part of the Brave ads service #6239

Closed
gdregalo opened this issue Sep 30, 2019 · 1 comment
Closed

Refactor reset state business logic to be part of the Brave ads service #6239

gdregalo opened this issue Sep 30, 2019 · 1 comment
Labels
closed/wontfix dev-concern feature/ads QA/No release-notes/exclude

Comments

@gdregalo
Copy link

gdregalo commented Sep 30, 2019 •
edited
Loading

Description

Issue about Reset state logic.
PR: brave/brave-core#3499
Logic to reset state should be part of bat-native-ads so that same business logic can be used cross-platform, i.e. iOS, Android and desktop
brave/brave-core#3499 (comment)

Please also update reset logic for Rewards service:
https://github.com/brave/brave-core/pull/3499/files#r330222132

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@gdregalo gdregalo mentioned this issue Sep 30, 2019
Merged
32 tasks
@jsecretan jsecretan added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 21, 2019
@tmancey tmancey added OS/Android Fixes related to Android browser functionality and removed OS/Android Fixes related to Android browser functionality labels Jan 20, 2020
@tmancey tmancey added dev-concern OS/Android Fixes related to Android browser functionality and removed priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality labels Jan 20, 2020
@tmancey tmancey changed the title Reset state should be part of bat-native-ads. PR# 3499. Refactor reset state business logic to be part of the Brave ads service May 5, 2020
@tmancey
Copy link
Contributor

tmancey commented Jul 28, 2020

Closing issue as resolved by #10064

@tmancey tmancey closed this as completed Jul 28, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/wontfix dev-concern feature/ads QA/No release-notes/exclude
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsecretan @tmancey @NejcZdovc @gdregalo