Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip button is only shown on stars tab of user profile when logged in to github #6266

Closed
btlechowski opened this issue Oct 1, 2019 · 1 comment
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

Follow up to: #5040
Tip button on stars tab of user profile only shows when logged in to github

Steps to Reproduce

  1. Clean profile
  2. Enable rewards
  3. Open https://github.com/feross?tab=stars

Note: after login in to github, the Tip button is shown

Actual result:

Tip button on stars tab of user profile is not shown
image

Expected result:

Tip button is shown even when not logged in to github
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @NejcZdovc @jdkuki

@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Nov 18, 2019
@NejcZdovc
Copy link
Contributor

@alexwykoff this happens because we tight it to star button. What should we do in this case?

@NejcZdovc NejcZdovc added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Apr 10, 2020
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

3 participants